Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify checking for entity creation #925 #926

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Modify checking for entity creation #925 #926

merged 1 commit into from
Jun 7, 2020

Conversation

socar-brad
Copy link
Contributor

Created entity using new(id: ID?, ...) method has id._value.
Then id._value == null can't check for entity creation.

These entities are in transaction entity cache's inserts.
And I fixed #925 using it.

@Tapac Tapac self-requested a review June 6, 2020 23:16
@Tapac Tapac merged commit 43d6ab1 into JetBrains:master Jun 7, 2020
@socar-brad socar-brad deleted the fix-new-with-id-and-refresh branch June 7, 2020 23:45
Tapac added a commit that referenced this pull request Jun 12, 2020
@Tapac
Modify checking for entity creation #925 (#926) / Exclude SQLServer f…
f96cfba 
…rom test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tapac Tapac Awaiting requested review from Tapac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't insert newly created entity if create an entity using new(id: ID?, ...) and refresh it
2 participants
@socar-brad @Tapac